- From: David Schleef <ds_at_schleef.org>
- Date: Thu, 18 Jul 2002 09:55:36 -0700
On Thu, Jul 18, 2002 at 10:38:03AM +0200, Rolf Mueller wrote: > Do you think, the sequence of register accesses from the stand-alone > examples could/should be merged into comedi? If so, how? Find out what is different, and find the minimal change that will fix it. It will probably be one or two register writes, nothing more. > What I like > about the examples is that they have the register accesses parceled > out nicely into functions (e.g., for resetting ai, board > configuration, MSC clock configuration, clearing the FIFO, board > personalization, ...) Would it make sense to have such functions in > comedi as well? Bad idea. Instead of an 80k driver, it would be a 200k driver. And to understand a simple sequence of 8 register writes, you have to search through 8 different functions. It's a good format for an example, but bad for a driver. It adds another layer of abstraction, when the ni_mio_common driver already has too many. dave...
Received on 2002-07-18Z15:55:36