suggest rvfree in mite_buf_alloc

• From: Tomasz Motylewski <motyl_at_stan.chemie.unibas.ch>
• Date: Sat, 9 Nov 2002 21:02:46 +0100 (CET)

Is there any reason for the following code in mite_buf_alloc:

               {
                        unsigned long addr = (unsigned long)async->prealloc_buf;
                        unsigned long size = async->prealloc_bufsz;
                        unsigned long page;

                        while(size>0){
                                page = kvirt_to_pa(addr);

mem_map_unreserve(virt_to_page(__va(page)));
                                addr += PAGE_SIZE;
                                size -= PAGE_SIZE;
                        }
                }
                vfree(async->prealloc_buf);


while rvfree() function is available which does just that?

Same applies to next part which could use rvmalloc.

Besides it could check some special flag in async flags and then ONLY call
mite_load_buffer without touching prealloc_buf and bufsize.

Best regards,
--
Tomek

Received on 2002-11-09Z20:02:46