buffer allocation also for configuration instructions?

The implementation of do_insn_ioctl() in comedi_fops.c suggests that a
buffer of MAX_SAMPLES samples is allocated for _all_ instructions,
even if these instructions have no acquisition data (e.g.,
configuration or INSN_INTTRIG instructions).

The implementation of parse_insn() in comedi_fops.c places the
INSN_INTTRIG instruction with the "non-subdevice instructions" (at
least in the comment of the code), although the processing of this
instructions does involve quite some subdevice data. One of the
results is that the INSN_INTTRIG instruction is not tested on locking,
being busy, and having a well-fromed channel spec. Is this a problem?

Herman
-- 
  K.U.Leuven, Mechanical Engineering, Robotics Research Group
<http://people.mech.kuleuven.ac.be/~bruyninc> Tel: +32 16 322480

Received on 2003-04-30Z19:59:02