Typo in driver for Advantech PCI DIO cards

Working through my first experiments with Comedi/Comedilib and my Advantech
PCI 1753 DIO card I found a typo in the driver program adv_pci_dio.c
One of the Interrupt Control registers of the PCI-1753 card has a wrong 
offset definition.

Round about line 100 in the file comedi-0.7.67/comedi/drivers/adv_pci_dio.c
the following #define occurs:

#define PCI1753_IRC3    48    /* R/W: Interrupt Control Register group 0 */

This line should read:

#define PCI1753_IRC3    20    /* R/W: Interrupt Control Register group 3 */

-----

Looking in the Advantech User's Manual for this particula card I found 
that this
register has address BASE+19 in the Advantech register format table.
Each define of the PCO-1753's addresses in adv_pci_dio.c is one count higher
then found in the Avantech Manual, except for the

#define PCI1753_DIO    0    /* Begin of 8255 registers block */

which is correct. (BASE+0)

I may be looking at it the wrong way, but it seems that all defines
are one count higher than they should be.....

Can someone explain why all these #defines are one count higher?
(Base+x+1, instead of just base+x)

Thanks,
Henk van Rooy

Received on 2004-03-11Z13:08:14