Re: Very minor flaw in cfc_write_array_to_buffer?

On Tuesday 08 February 2005 09:34 am, Ian Abbott wrote:
> Just nitpicking, but would it be better if the
> cfc_write_array_to_buffer() function checked for overflow using the
> comedi_buf_write_n_available() function instead of
> comedi_buf_write_alloc()?  At the moment, some space is allocated by
> comedi_buf_write_alloc() that is never used.  It doesn't matter too
> much, as the COMEDI_CB_OVERFLOW event will eventually cause the buffer
> to be reinitialized.

Well, probably it should just write as many samples as there is room for 
and let the caller decide if they want to set COMEDI_CB_OVERFLOW, on the 
small chance that a driver might be able to recover later.  I was probably 
just being lazy when I wrote it.

-- 
Frank