Re: [PATCH] check_region deprecated (maybe a nicer solution?)

On Tuesday 15 March 2005 12:01 pm, Ian Abbott wrote:
>
> I just defined _start and _n to avoid expanding the macro parameters
> more than once in case of side effects (an old GCC trick), but yes, a
> static inline function would be neater.  Using upper case for a function
> breaks naming conventions though.  Any suggestions?  I suggested
> 'comedi_request_region()' earlier, but a function with that name should
> probably go in comedidev.h.  Are LINUX_VERSION_CODE checks allowed in
> comedidev.h?

It should not go in comedidev.h.  The function would exist only for 
compatibility across kernel versions, and it belongs in the linux/mm.h 
compatibility header file.  If you care about people getting tricked into 
thinking it's a macro when it's an inline function (I don't) you can call 
it compat_request_region() or something like that.

-- 
Frank