Re: addi-data drivers

Frank Mori Hess wrote:
> On Wednesday 29 August 2007 06:09, Anders Blomdell wrote:
>> And here comes the full patch (I'll probably never learn how to use cvs
>> diff to properly handle local additions :-()
> 
> I have some suggestions:  the addi-data stuff should be built in its 
> subdirectory instead of being pulled up into comedi/drivers, so you want 
> to edit the Kbuild and Makefile.am in the addi-data subdirectory.  
Why handle the addi-data drivers differently from other drivers? If ADDI-DATA
had shown interest in maintaining their drivers, the current organization makes
sense (since restricted CVS access could be used). The drivers I build, is just
a quick hack to break apart the big monolitic driver into one driver per
card-type (and only stop building the drivers that need kernel floating point).

> See the 
> Kbuild file in the comedi subdir for an example of how to tell Kbuild to 
> go into a subdirectory (it's' trivial).  You don't really need to worry 
> about the non-Kbuild parts of the Makefile.am, that's broken anyways.
> 
> Also, would it be difficult to make addi_common a module instead of 
> including it into all the drivers?
I guess so, since addi_common.c declares boardtypes[] (which I blantantly break
apart by ugly ifdef's). I'm also not sure what it's worth, since it would only
matter if you have two different kinds of cards in the same computer (or am I
missing something?).

Best regards

Anders Blomdell



-- 
Anders Blomdell                  Email: anders.blomdell_at_control.lth.se
Department of Automatic Control
Lund University                  Phone:    +46 46 222 4625
P.O. Box 118                     Fax:      +46 46 138118
SE-221 00 Lund, Sweden

Received on 2007-09-03Z05:56:03