- From: Frank Mori Hess <fmhess_at_users.sourceforge.net>
- Date: Sun, 18 Jan 2004 12:47:35 -0500
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Monday 12 January 2004 11:45 am, Salvador Eduardo Tropea wrote: > Hi! > > Here is a second version of the 8254 counter stuff. > I commented the useless spin locks and added some 8254 specific > configuration. > The configuration command is INSN_CONFIG_8254 and it have 2 subcommands. > One is used to select the mode (0 to 5 and BCD/BINARY) and the other to > read the status (Output and NULL Count). I've got a couple quibbles before I commit your code. First, I'd like to keep the configuration instructions 'flat'. That is, just make two seperate configuration instructions instead of making subcommands for a single instruction. Second, your actual write to the control register should happen during the write instruction, and INSN_CONFIG_8254_SET_MODE should only store into memory the mode that will be used in subsequent writes. - -- Frank -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQFACsa45vihyNWuA4URAt8fAKC/qXpQQwANU0qJB8oc9D2sqEh+/wCcD+Eg BPKCNogDxTRTu0G9ZaMxVgY= =QAgD -----END PGP SIGNATURE-----
Received on 2004-01-18Z17:47:35