Re: Include Reorganization

On Sat, 17 Jul 2004, Frank Mori Hess wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Friday 16 July 2004 08:39 pm, Jonathan T Wang wrote:
> >
> > I moved the type definitions into comedi_types.h. This way, the header
> > file for the class dealing with comedi can just include comedi_types.h,
> > and the .cc file defining the class can include comedilib.h to get the
> > function calls it needs without giving the rest of the application
> > access to those calls.
> >
>
> That sounds okay if you want to make a patch, as long as you don't combine
> stuff from comedi.h and comedilib.h into the same file.  comedi.h defines
> the interface between comedi and comedilib.

Well, the problem is that many of the types needed by the user are defined
in comedi.h. comedi_trig, comedi_cmd, comedi_insn, etc. all are defined in
comedi.h. With the current includes the user gets these definitions as
comedilib.h includes comedi.h.

Jonathan

Received on 2004-07-17Z20:43:14